[
https://issues.apache.org/jira/browse/QPID-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403883#comment-13403883
]
Keith Wall commented on QPID-4089:
----------------------------------
Hi Alex
A couple of comments:
1) AggregatedSeriesResults#addMessageLatency appears to be unused.
2) The name AggregatedSeriesResults does not clearly identify the purpose of
the class. We've already used the word 'aggregation' elsewhere to mean the
process of summarising many ParticipantResults into a single
ParticipantResult. Since this is not the concern of this class, I'd use a
different word.
3)
ConsumerParticipantLatencyResult#ConsumerParticipantLatencyResult(ConsumerParticipantResult
result) is fragile. If a maintainer changes ConsumerParticipantResult they
now need to change this class too. I'd prefer we avoid this.
4) ConsumerParticipantLatencyResult typo Lateny
5) ConsumerParticipantResultAggregator#getLatencyAggregatedResults ununsed
6) ConsumerParticipantResultAggregator#getAggregatedResult(). I think this
method surprises the reader by returning a ConsumerParticipantLatencyResult. It
is also fragile as we have repeated implementation (calls to
setRolledUpConstantAttributes and setComputedVariableAttributes) from the base
class.
7) In some of the PNGs the x-labels are being ellipsis (...)
8) It would be nice if we could make use of error bars to show the stdev,
rather than the separate column (one for the future i think)
http://www.jfree.org/jfreechart/api/javadoc/org/jfree/chart/renderer/category/StatisticalBarRenderer.html
9) Suggestion: In the chartdef files, you could make use of chartSubtitle to
avoid some of the very long chart titles.
> Add latency tests into Java Performance Tests
> ---------------------------------------------
>
> Key: QPID-4089
> URL: https://issues.apache.org/jira/browse/QPID-4089
> Project: Qpid
> Issue Type: Task
> Components: Java Performance Tests
> Affects Versions: 0.17
> Reporter: Alex Rudyy
> Assignee: Keith Wall
> Fix For: 0.17
>
> Attachments:
> 0001-QPID-4089-Add-latency-tests-into-Java-Performance-Te.patch
>
>
> We need to implement a group of tests measuring latency metrics (minimum
> latency, maximum latency, average latency, standard deviation) by varying the
> following attributes:
> queue type
> message size
> number of producers and consumers
> selectors
> The publishing rate should be deliberately limited in such tests to never
> throttle the broker or exceed the consumption rate.
> Ideally, a special configuration parameter like expectedPublishingRate can be
> added to control publishing, however, we can use currently implemented
> "interval" parameter. We can also publish data in small batches with delays
> between batches.
> Also, it would be interesting to see comparison of latency vs throughput by
> varying the publishing rate.
> Publishing in AA mode is only required for initial latency tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
