On Tue, 2012-07-10 at 15:04 -0400, Andrew Stitcher wrote: > On Tue, 2012-07-10 at 13:34 -0400, Rafael Schloming wrote: > > What was the source of these warnings? If it's the generated swig code, > > we should probably fix this by excluding these macros from the swigged > > interface as they are useless in the target language anyways. > > Those macro definitions make the C code have undefined effect. > > In other words as written the headers files have no defined meaning in > C. > > So irrespective of the warning they need to be changed. > > Andrew > > [In case I need to point it out: Identifiers starting with an underscore > and an uppercase character are reserved to the implementation]
FWIW, the leading underscore appears to be the de facto convention for this sort of thing, although I take your point that it's technically in violation of the standard. I certainly don't mind removing the underscore, but either way, we still shouldn't be generating swig wrappers for these macros, and apparently swig does generate them by default: >>> print cproton._PROTON_ENGINE_H 1 >>> --Rafael --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
