I can't really comment on the specific changes as I have no experience with those bits, but the simplified focus seems reasonable to me.
Robbie On 18 July 2012 14:28, Darryl L. Pierce <[email protected]> wrote: > On Fri, Jul 13, 2012 at 01:56:42PM -0400, Darryl L. Pierce wrote: > > On Thu, Jul 12, 2012 at 03:29:52PM -0400, Darryl L. Pierce wrote: > > > Please consider the following patch for inclusion in 0.18: > > > > > > https://issues.apache.org/jira/browse/QPID-4134 > > > > > > This patch set provides a new target for release.sh to bundle together > > > the Perl sources. It also includes changes to the CMakeLists.txt and > two > > > new files in the bindings/qpid/perl directory. > > > > Based on feedback, I dialed this back to something a bit simpler. > > > > Now, instead, this patch provides just the Cmake target for producing > > the Perl sources for perl-qpid. It no longer adds a target to the > > release.sh file, and does not touch the autotools system at all. > > > > Still would like this to go into 0.18. > > Any opinions on including this? > > -- > Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > Delivering value year after year. > Red Hat ranks #1 in value among software vendors. > http://www.redhat.com/promo/vendor/ > >
