[
https://issues.apache.org/jira/browse/QPID-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436684#comment-13436684
]
Keith Wall commented on QPID-4220:
----------------------------------
Hi Alex,
As requested, I took a look of at your patch.
Like you, I'm a bit uncomfortable with the new custom deserialiser code in this
patch, it looks quite fragile. I haven't used Jackson much, but I think I
would take a look at annotations as I suspect this would end up being more
robust.
I'm find with the json normalisation. I see no reason for the mixture in
separators we have today. In fact, I'd be tempted to submit the json
normalisation as a separate patch (same Jira) so we can commit immediately
before it has chance to rot.
HTH.
> Use single json processing library acrross all modules in java modules tree
> ----------------------------------------------------------------------------
>
> Key: QPID-4220
> URL: https://issues.apache.org/jira/browse/QPID-4220
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.19
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments:
> 0001-QPID-4220-Replace-gson-library-with-jackson-in-perft.patch
>
>
> Currently java modules tree has dependencies on 2 json processing libraries:
> jackson and gson. jackson library is used in http management, gson is used in
> perftests library. In order to unify the usage of libraries and reduce the
> dependencies the perftests module needs to be changed to use jackson json
> parser and mapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
