-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6888/
-----------------------------------------------------------

Review request for qpid, Chug Rolke and Cliff Jansen.


Description
-------

Expanded version of the original submitted patch for QPID-4269. It enables the 
broker started as a service to take command line args from 2 places: args 
supplied after the executable spec when the service is installed, and args 
supplied to the StartService function (which are commonly provided in the 
service's Properties box when starting it). Command line (when installed) args 
are ordered first so they can be overridden by args provided in the start 
dialog box.


This addresses bug QPID-4269.
    https://issues.apache.org/jira/browse/QPID-4269


Diffs
-----

  /trunk/qpid/cpp/src/windows/QpiddBroker.cpp 1379241 

Diff: https://reviews.apache.org/r/6888/diff/


Testing
-------

Build; install service w/ args - start it. Stop it. Start with extra args 
provided in Properties and verify all the args are seen and acted on. I had 
QPID_LOG statements in there to assist in debugging - these have been removed 
now and are not in the patch.


Thanks,

Steve Huston

Reply via email to