-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6955/
-----------------------------------------------------------

Review request for qpid, Ted Ross and Pavel Moravec.


Description
-------

Here's a modified version of Pavel's original patch that includes the full 
properties list as provided by the client when the connection is created.

Using qpid-printevents, you can see the property map in the event:

Fetched Message(properties={u'qmf.agent': 
u'apache.org:qpidd:a2ff61bc-19b2-4078-8a7e-9c007151c79c', 
'x-amqp-0-10.routing-key': 
u'agent.ind.event.org_apache_qpid_broker.clientConnect.info.apache_org.qpidd.a2ff61bc-19b2-4078-8a7e-9c007151c79c',
 'x-amqp-0-10.app-id': 'qmf2', u'qmf.content': u'_event', u'qmf.opcode': 
u'_data_indication', u'method': u'indication'}, content=[{u'_schema_id': 
{u'_package_name': 'org.apache.qpid.broker', u'_class_name': 'clientConnect', 
u'_type': '_event', u'_hash': UUID('476930ed-01dd-9629-7f84-f42b4b0bc410')}, 
u'_timestamp': 1347032560197086881, u'_values': {u'user': 'anonymous', 
u'properties': {u'qpid.session_flow': 1, u'qpid.client_ppid': 26139, 
u'qpid.client_pid': 26876, u'qpid.client_process': u'spout'}, u'rhost': 
'127.0.0.1:5672-127.0.0.1:43276'}, u'_severity': 6}])
Fri Sep  7 15:42:40 2012 org.apache.qpid.broker:clientConnect user=anonymous 
properties={u'qpid.session_flow': 1, u'qpid.client_ppid': 26139, 
u'qpid.client_pid': 26876, u'qpid.client_process': u'spout'} 
rhost=127.0.0.1:5672-127.0.0.1:43276
Fetched Message(properties={u'qmf.agent': 
u'apache.org:qpidd:a2ff61bc-19b2-4078-8a7e-9c007151c79c', 
'x-amqp-0-10.routing-key': 
u'agent.ind.event.org_apache_qpid_broker.clientDisconnect.info.apache_org.qpidd.a2ff61bc-19b2-4078-8a7e-9c007151c79c',
 'x-amqp-0-10.app-id': 'qmf2', u'qmf.content': u'_event', u'qmf.opcode': 
u'_data_indication', u'method': u'indication'}, content=[{u'_schema_id': 
{u'_package_name': 'org.apache.qpid.broker', u'_class_name': 
'clientDisconnect', u'_type': '_event', u'_hash': 
UUID('e7603e45-c89b-ea2f-3335-48c0980369db')}, u'_timestamp': 
1347032560239676462, u'_values': {u'user': 'anonymous', u'properties': 
{u'qpid.session_flow': 1, u'qpid.client_ppid': 26139, u'qpid.client_pid': 
26876, u'qpid.client_process': u'spout'}, u'rhost': 
'127.0.0.1:5672-127.0.0.1:43276'}, u'_severity': 6}])
Fri Sep  7 15:42:40 2012 org.apache.qpid.broker:clientDisconnect user=anonymous 
properties={u'qpid.session_flow': 1, u'qpid.client_ppid': 26139, 
u'qpid.client_pid': 26876, u'qpid.client_process': u'spout'} 
rhost=127.0.0.1:5672-127.0.0.1:43276


This addresses bug qpid-4174.
    https://issues.apache.org/jira/browse/qpid-4174


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1382075 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1382075 
  /trunk/qpid/specs/management-schema.xml 1382075 

Diff: https://reviews.apache.org/r/6955/diff/


Testing
-------

Just checked the new event contents with qpid-printevents


Thanks,

Kenneth Giusti

Reply via email to