----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/462/ -----------------------------------------------------------
(Updated Nov. 4, 2012, 10:56 p.m.)
Review request for qpid.
Changes
-------
* Fixed a bug in the conversion of PHP NULL values to QVariants.
* Fixed build error when using PHP 5.4.0+
* Fixed an error with the install target for out-of-tree cmake builds.
* Patched the combined bindings/CMakeLists.txt file added in r1400781 (ie Qpid
0.19+)
Description
-------
A SWIG-based PHP binding for the Qpid Messaging API.
The SWIG-based binding itself is complete, and working (hence needing review).
This diff includes integration with Qpid's autoconf build system. I've only
just begun learning autoconf / automake, so the build integration definitely
needs review too :)
This addresses bug QPID-3027.
https://issues.apache.org/jira/browse/QPID-3027
Diffs (updated)
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/CMakeLists.txt
1405640
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qmf2/Makefile.am
1405640
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qmf2/examples/php/cli/list_agents.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qmf2/php/CMakeLists.txt
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qmf2/php/Makefile.am
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qmf2/php/php.i
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/Makefile.am
1405640
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/cli/client.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/cli/hello_world.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/cli/map_receiver.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/cli/map_sender.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/cli/server.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/examples/php/web/hello_world.php
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/php/CMakeLists.txt
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/php/Makefile.am
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/php/php.i
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/qpid/php/phpinfo.i
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/bindings/swig_php_typemaps.i
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/configure.ac 1405640
Diff: https://reviews.apache.org/r/462/diff/
Testing
-------
Thanks,
Paul Colby
