-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7932/
-----------------------------------------------------------
Review request for qpid, rajith attapattu, Rafael Schloming, and Rob Godfrey.
Description
-------
Driver changes to align more closely with the C implementation in order that
the Messenger API which relies on this can remain similar in implementation.
More specifically:
* removed the special SASL handling from ConnectorImpl as that is already done
in the Transport
* cleaned up use of buffers in ConnectorImpl through standard means and as
arrays
* made DriverImpl track connectors and listeners
* ensure that process() can be called multiple times between select calls, but
the socket is read only once (else you get data read in that hasn't been fully
reacted to, but you don't get a further notification for).
* exposed some exceptions rather than trying to mask them (this may be
controversial; it seemed neater and more natural to me).
This addresses bug PROTON-118.
https://issues.apache.org/jira/browse/PROTON-118
Diffs
-----
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/Connector.java
1406092
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/Driver.java
1406092
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/Listener.java
1406092
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/ConnectorImpl.java
1406092
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/DriverImpl.java
1406092
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/driver/impl/ListenerImpl.java
1406092
Diff: https://reviews.apache.org/r/7932/diff/
Testing
-------
In conjunction with the Messenger implementation (submitted as separate patch
for same JIRA), the common test suite has been run with no new failures
(acknowledgement related messenger tests fail as that is not yet implement,
send&receive test fails for messages over 10k).
Thanks,
Gordon Sim
