-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7934/
-----------------------------------------------------------
(Updated Nov. 8, 2012, 1:58 p.m.)
Review request for qpid, Robbie Gemmell, rajith attapattu, Keith Wall, Rafael
Schloming, and Rob Godfrey.
Changes
-------
Added missing MessengerException class. Corrected bracketing to match current
project coding-style more consistently.
Description
-------
Added Messenger API and impl. Probably need some sort of factory if we keep
this split to avoid direct construction of the impl class.
Doesn't yet support acknowledgements (thats coming next, though).
This addresses bug PROTON-118.
https://issues.apache.org/jira/browse/PROTON-118
Diffs (updated)
-----
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/Messenger.java
PRE-CREATION
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/MessengerException.java
PRE-CREATION
/proton/trunk/proton-j/src/main/java/org/apache/qpid/proton/messenger/impl/MessengerImpl.java
PRE-CREATION
/proton/trunk/proton-j/src/main/scripts/proton.py 1406092
/proton/trunk/tests/proton_tests/messenger.py 1406092
Diff: https://reviews.apache.org/r/7934/diff/
Testing
-------
In conjunction with the Driver changes (submitted as separate patch for same
JIRA) and the patch attached to PROTON-120, the common test suite has been run
with no new failures. The messenger tests have been enabled and the shim
modified. The acknowledgement related messenger tests fail as that is not yet
implemented, send&receive test fails for messages over 10k (I think that may be
an engine issue but will dig some more).
Thanks,
Gordon Sim
