-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8021/
-----------------------------------------------------------
(Updated Nov. 13, 2012, 3:08 p.m.)
Review request for qpid, Andrew Stitcher and Rafael Schloming.
Changes
-------
Updated with review feedback.
Description
-------
Attached is an attempt at adding Connection idle-time-out support to Proton-c,
as defined by the AMQP 1.0 spec.
Notes:
1) Allows configuration of the AMQP Connection idle timeout locally, and
support for receiving the remote's configured idle timeout.
2) Will send periodic keepalive (empty) frames to satisfy remote's idle
requirements, if needed.
3) Will close the connection if remote violates the locally configured idle
deadline
This addresses bug proton-111.
https://issues.apache.org/jira/browse/proton-111
Diffs (updated)
-----
/proton/trunk/proton-c/CMakeLists.txt 1408412
/proton/trunk/proton-c/bindings/python/proton.py 1408412
/proton/trunk/proton-c/include/proton/driver.h 1408412
/proton/trunk/proton-c/include/proton/engine.h 1408412
/proton/trunk/proton-c/include/proton/types.h 1408412
/proton/trunk/proton-c/src/dispatcher/dispatcher.h 1408412
/proton/trunk/proton-c/src/dispatcher/dispatcher.c 1408412
/proton/trunk/proton-c/src/driver.c 1408412
/proton/trunk/proton-c/src/engine/engine-internal.h 1408412
/proton/trunk/proton-c/src/engine/engine.c 1408412
/proton/trunk/proton-c/src/messenger.c 1408412
/proton/trunk/proton-c/src/util.h 1408412
/proton/trunk/proton-c/src/util.c 1408412
/proton/trunk/proton-j/src/main/scripts/proton.py 1408412
/proton/trunk/tests/proton_tests/engine.py 1408412
Diff: https://reviews.apache.org/r/8021/diff/
Testing
-------
Added an engine test case to verify that the timers are tracked, and the action
when timers fire, but I need to add a test at the driver level, too.
Thanks,
Kenneth Giusti
