-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8321/
-----------------------------------------------------------

(Updated Dec. 4, 2012, 10:20 p.m.)


Review request for qpid.


Changes
-------

Check for MacOS X platform and override building stuff that isn't possible there


Description
-------

These changes move in the direction of abstracting away some portability 
problems with the current proton code base:
- Detection of correct API for uuids;
- Detection of correct API for clock_gettime()/gettimeofday()
- Handling ignoring SIGPIPE on writing to closed sockets
- Allowing warnings to be turned of whilst building (but having them on is 
still the default)

You can also see (and comment) on these changes at github:
https://github.com/astitcher/qpid-proton/commits/portability


This addresses bugs proton-104, proton-105, proton-106, proton-108, and 
proton-168.
    https://issues.apache.org/jira/browse/proton-104
    https://issues.apache.org/jira/browse/proton-105
    https://issues.apache.org/jira/browse/proton-106
    https://issues.apache.org/jira/browse/proton-108
    https://issues.apache.org/jira/browse/proton-168


Diffs (updated)
-----

  /proton/trunk/proton-c/CMakeLists.txt 1415142 
  /proton/trunk/proton-c/bindings/CMakeLists.txt 1415142 
  /proton/trunk/proton-c/bindings/php/CMakeLists.txt 1415142 
  /proton/trunk/proton-c/bindings/python/CMakeLists.txt 1415142 
  /proton/trunk/proton-c/bindings/ruby/CMakeLists.txt 1415142 
  /proton/trunk/proton-c/include/proton/driver.h 1415142 
  /proton/trunk/proton-c/src/driver.c 1415142 
  /proton/trunk/proton-c/src/messenger.c 1415142 
  /proton/trunk/proton-c/src/platform.h PRE-CREATION 
  /proton/trunk/proton-c/src/platform.c PRE-CREATION 

Diff: https://reviews.apache.org/r/8321/diff/


Testing
-------

Compiles and passes the proton-test suite on both Fedora 17 and FreeBSD


Thanks,

Andrew Stitcher

Reply via email to