Wouldn't it be cleaner to implement those functions as macros for the platforms that don't define it?
On Fri, Dec 7, 2012 at 4:19 AM, Cliff Jansen <cliffjan...@gmail.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8385/#review14146 > ----------------------------------------------------------- > > > This looks good from a portability perspective. But it must present a > performance penalty on big endian hardware, though I can't quantify the > amount. Are these functions not available on some platform? > > - Cliff Jansen > > > On Dec. 6, 2012, 11:10 p.m., Andrew Stitcher wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/8385/ > > ----------------------------------------------------------- > > > > (Updated Dec. 6, 2012, 11:10 p.m.) > > > > > > Review request for qpid, Cliff Jansen and Rafael Schloming. > > > > > > Description > > ------- > > > > Removed the use of [nh]to[hn][ls] in the ANSI only part of the code as > they are part of BSD sockets API not in ANSI C. > > > > There is now some duplication of code which should be removed, but > nothing serious in my opinion. > > > > > > This addresses bug PROTON-121. > > https://issues.apache.org/jira/browse/PROTON-121 > > > > > > Diffs > > ----- > > > > /proton/trunk/proton-c/src/codec/codec.c 1417656 > > /proton/trunk/proton-c/src/framing/framing.c 1417656 > > > > Diff: https://reviews.apache.org/r/8385/diff/ > > > > > > Testing > > ------- > > > > Compiled under Fedora and run proton-test against the built code. > > > > > > Thanks, > > > > Andrew Stitcher > > > > > > -- ** *Hiram Chirino* *Engineering | Red Hat, Inc.* *hchir...@redhat.com <hchir...@redhat.com> | fusesource.com | redhat.com* *skype: hiramchirino | twitter: @hiramchirino<http://twitter.com/hiramchirino> * *blog: Hiram Chirino's Bit Mojo <http://hiramchirino.com/blog/>*
