[ https://issues.apache.org/jira/browse/QPID-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528221#comment-13528221 ]
Rajith Attapattu commented on QPID-4496: ---------------------------------------- I have fixed the typo and corrected the code to conform to the coding style. Some of the existing tests implicitly covers this. However I think we need to add some tests that specifically tests for error handling, not just this particular issue. I'm looking into it now. > [Java client] Improve error reporting for invalid addresses > ----------------------------------------------------------- > > Key: QPID-4496 > URL: https://issues.apache.org/jira/browse/QPID-4496 > Project: Qpid > Issue Type: Bug > Components: Java Client > Affects Versions: 0.18, 0.20 > Reporter: Rajith Attapattu > Assignee: Rajith Attapattu > Labels: addressing, jms > Fix For: 0.21 > > > In the following example, the second address should throw an exception > notifying that the request type is different from the already present object > 1. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, > node: {type:topic,x-declare:{type:topic}}}" > 2. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, > node: {type:topic,x-declare:{type:fanout}}}" > Also we need to provide a clear messages when an assertion is false. > Ex. > 1. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{create:sender, > node: {type:topic,x-declare:{type:topic}}}" > 2. java -cp ${CLASSPATH} org.apache.qpid.example.Spout "ex;{assert:sender, > node: {type:topic,x-declare:{type:fanout}}}" > All though we currently throw an exception, the message is not very useful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org