----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8331/#review14293 -----------------------------------------------------------
I've reviewed this work from a proton-j point of view, so have only really looked at the Python changes. Unless requested otherwise I will commit my proposed changes to Ken's work-in-progress SVN branch tomorrow, allowing a new diff to be generated and publicly reviewed. /proton/trunk/tests/proton_tests/ssl.py <https://reviews.apache.org/r/8331/#comment30446> Would it be possible to pass the session key as an object (eg SSLSessionDetails) rather than a string? Java uses a hostname/port pair to look up SSL sessions, so I intend proton-j's SSLSessionDetails implementation to wrap this pair. proton-c's implementation would simply wrap the string. /proton/trunk/tests/proton_tests/ssl.py <https://reviews.apache.org/r/8331/#comment30448> I'm not sure if there is an easy way for proton-j to return a meaningful value from ssl.resume_status(). Some of the methods on Java's SSLSession object *may* allow me infer this information, but if not then we'll need to consider alternative ways for the test to make this assertion. I'll try it out and get back to you - watch this space. - Philip Harvey On Dec. 10, 2012, 7:56 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8331/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 7:56 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Description > ------- > > Support for client-driven SSL session resumption. More testing is needed, > but the API changes are pretty extensive so I wanted to get some wider > visibility sooner rather than later. > > I'll provide in-code API documentation before I check in, but for now you can > reference the original JIRA for the background. > > > This addresses bug PROTON-136. > https://issues.apache.org/jira/browse/PROTON-136 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1419706 > /proton/trunk/proton-c/include/proton/ssl.h 1419706 > /proton/trunk/proton-c/src/ssl/openssl.c 1419706 > /proton/trunk/proton-c/src/ssl/ssl_stub.c 1419706 > /proton/trunk/tests/proton_tests/ssl.py 1419706 > > Diff: https://reviews.apache.org/r/8331/diff/ > > > Testing > ------- > > Original unit tests pass, added two more specific to these changes. No 3rd > party interopt testing yet. > > > Thanks, > > Kenneth Giusti > >
