----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8449/#review14503 -----------------------------------------------------------
Ship it! One final comment on the naming of the enumeration. It strikes me that VERIFY_PEER_NAME sounds like it does less than VERIFY_PEER, although actually it's doing more. I also think the default should be to do the host check, so maybe we should have VERIFY_PEER do the full check and then introduce some other name to do the partial check. Happy to ship it now though and tweak the names later. - Rafael Schloming On Dec. 13, 2012, 10:51 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8449/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2012, 10:51 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Description > ------- > > Adds an API call to set the hostname which is used for Server Name Indication > as well as Common Name matching. Right now only support exact text match - > no wildcarding. > > > This addresses bug proton-161. > https://issues.apache.org/jira/browse/proton-161 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1420994 > /proton/trunk/proton-c/bindings/python/python.i 1420994 > /proton/trunk/proton-c/include/proton/ssl.h 1420994 > /proton/trunk/proton-c/src/ssl/openssl.c 1420994 > /proton/trunk/proton-c/src/ssl/ssl_stub.c 1420994 > /proton/trunk/tests/proton_tests/ssl.py 1420994 > /proton/trunk/tests/proton_tests/ssl_db/README.txt 1420994 > /proton/trunk/tests/proton_tests/ssl_db/ca-certificate.pem 1420994 > /proton/trunk/tests/proton_tests/ssl_db/ca-private-key.pem PRE-CREATION > /proton/trunk/tests/proton_tests/ssl_db/client-certificate.pem 1420994 > /proton/trunk/tests/proton_tests/ssl_db/client-private-key.pem 1420994 > /proton/trunk/tests/proton_tests/ssl_db/server-certificate.pem 1420994 > /proton/trunk/tests/proton_tests/ssl_db/server-private-key.pem 1420994 > > Diff: https://reviews.apache.org/r/8449/diff/ > > > Testing > ------- > > Updated ssl unit tests. > > > Thanks, > > Kenneth Giusti > >
