Thanks Andrew. I have just updated the patch a bit to remove generate.sh and to better integrate the stuff into the main Java build. I'll commit it tomorrow unless I receive suggestion otherwise.
Robbie. On 17 December 2012 20:38, Andrew Stitcher <[email protected]> wrote: > On Mon, 2012-12-17 at 14:26 +0000, Robbie Gemmell wrote: > > Hi all, > > > > I raised QPID-4458 to remove a couple of jars in the gentools dir from > the > > repo (I didnt notice them when doing QPID-3994) and have them downloaded > > using Ivy instead like all the other dependencies are. In re-doing the > > changes (first attempt missed a bit) I decided to look into what actually > > uses the contents of the qpid/gentools dir, and in the end I think it > could > > be only the Java tree that uses it (and only some of it at that). Does > > anyone know differently? > > > > It appears the C++ tree uses a ruby based generator, and I only spotted > one > > reference to gentools in qpid/cpp/src/generate.sh. That reference is in > > form of a compilation attempt, and im not sure that it would even work as > > it doesnt seem to supply the Velocity dependencies in the classpath. I > also > > didnt find anything referencing that script, is it actually used anymore? > > > > I'm pretty sure that the C++ build stopped using gentool a loong while > ago (perhaps 4 years?). So if the javaj build still requires it it does > indeed make sense for it to be in the java tree. > > I don't think that generate.sh is ever used in the c++ build, so it can > probably be removed completely. > > Andrew > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
