-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8804/
-----------------------------------------------------------

Review request for qpid and Kenneth Giusti.


Description
-------

This change removes the ad hoc deconstruction of Connection management ids to 
discover the end points of the Connection so that they can be used by to look 
up a Link in the LinkRegistry.

Instead we allow the federation code to specify the management id of the 
Connection directly then use this specified name as an index to find the Link 
directly.

Currently this makes the Connnection id identical to the Link name that is 
using the connection, it would be easy to change this to some other convention, 
but this seems simple.


This addresses bug qpid-4315.
    https://issues.apache.org/jira/browse/qpid-4315


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1426152 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/broker/Link.h 1426152 
  /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.h 1426152 
  /trunk/qpid/cpp/src/qpid/sys/AsynchIOHandler.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/sys/ProtocolFactory.h 1426152 
  /trunk/qpid/cpp/src/qpid/sys/RdmaIOPlugin.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1426152 
  /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1426152 

Diff: https://reviews.apache.org/r/8804/diff/


Testing
-------

Passes make check


Thanks,

Andrew Stitcher

Reply via email to