> On Jan. 25, 2013, 7:01 p.m., Kenneth Giusti wrote: > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c, > > line 717 > > <https://reviews.apache.org/r/9085/diff/1/?file=251495#file251495line717> > > > > If/when possible, I'd prefer declaring these as pointer-to-const, > > rather than casting away the const-ness. > > > > That probably requires more changes to any functions that take them as > > arguments (like parse_url), but that's for the best. IMHO the proton-c > > codebase doesn't use 'const' correctly in a lot of cases.
I created a separate issue to fix this. https://issues.apache.org/jira/browse/PROTON-206 - Cliff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/#review15700 ----------------------------------------------------------- On Jan. 24, 2013, 8:24 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9085/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 8:24 a.m.) > > > Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, > and Mary Hinton. > > > Description > ------- > > gcc flag "-write-strings" that provides c++ checking > > > This addresses bug proton-159. > https://issues.apache.org/jira/browse/proton-159 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/recv.c > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/send.c > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/util.h > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.h > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/dispatcher/dispatcher.c > 1435762 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c > 1435762 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c > 1435762 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/ssl/openssl.c > 1435762 > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/util.c > 1435762 > > Diff: https://reviews.apache.org/r/9085/diff/ > > > Testing > ------- > > compiles on linux and runs proton test. Along with other patches, also > compiles in Visual Studio. > > > Thanks, > > Cliff Jansen > >
