[
https://issues.apache.org/jira/browse/QPID-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565895#comment-13565895
]
Keith Wall commented on QPID-4533:
----------------------------------
Hi Phil,
Just a couple of comments:
1) The new files ResultsDbWriter, ResultsDbWriterTest, ResultsTestFixture are
missing their licence.
2) ResultsDbWriter - why do you call driverClass.newInstance()? Won't loading
the class be sufficient to register the driver?
3) Typo in ControllerRunner._resuResultsFileWriter
4) TODO left in JdbcCsvSeriesBuilder (i agree with your suggestion to rename)
5) JdbcCsvSeriesBuilder - misplaced member variable _callback
6) JdbcCsvSeriesBuilder - zero arg constructor is unused
7) How are we intending to constrain the growth of the database to prevent the
need for manual intervention?
cheers, Keith.
> Java broker performance tests should support writing results to database
> ------------------------------------------------------------------------
>
> Key: QPID-4533
> URL: https://issues.apache.org/jira/browse/QPID-4533
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Affects Versions: 0.20
> Reporter: Philip Harvey
> Assignee: Keith Wall
> Priority: Minor
> Attachments:
> 0002-QPID-4533-Modified-perftests-to-support-writing-resu.patch,
> timeseries.chartdef
>
>
> We should allow perftest results to be written to a database to facilitate
> analysis, eg charting how our performance has varied over time
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
