> On Jan. 30, 2013, 2:55 p.m., Chug Rolke wrote: > > /trunk/qpid/tools/src/py/qpid-cluster, line 296 > > <https://reviews.apache.org/r/9139/diff/1/?file=253002#file253002line296> > > > > This instance is missing the pattern 'if not opts.ssl_certificate:'
Actually, the options checking for that particular file (qpid-cluster) is a bit different than the rest - it is done earlier in the code. So, the pattern is there, but a bit further up the file - see line 284 in the patched file. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9139/#review15848 ----------------------------------------------------------- On Jan. 29, 2013, 9:32 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9139/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 9:32 p.m.) > > > Review request for qpid and Chug Rolke. > > > Description > ------- > > Corrects the SSL parameter name that is passed by the tools to the QPID > Python client. > > > This addresses bug qpid-4554. > https://issues.apache.org/jira/browse/qpid-4554 > > > Diffs > ----- > > /trunk/qpid/tools/src/py/qpid-cluster 1439431 > /trunk/qpid/tools/src/py/qpid-config 1439431 > /trunk/qpid/tools/src/py/qpid-ha 1439431 > /trunk/qpid/tools/src/py/qpid-printevents 1439431 > /trunk/qpid/tools/src/py/qpid-queue-stats 1439431 > /trunk/qpid/tools/src/py/qpid-route 1439431 > /trunk/qpid/tools/src/py/qpid-stat 1439431 > > Diff: https://reviews.apache.org/r/9139/diff/ > > > Testing > ------- > > Unit tests > > > Thanks, > > Kenneth Giusti > >
