----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9299/#review16078 -----------------------------------------------------------
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h <https://reviews.apache.org/r/9299/#comment34400> It's a little odd that you need this here, when the individual include files must have it. - Andrew Stitcher On Feb. 5, 2013, 2:33 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9299/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 2:33 a.m.) > > > Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, > and Mary Hinton. > > > Description > ------- > > Changes for specifying symbol import/export needed for Visual Studio. > > Copied with minor variances from the qpid/cpp tree. The first half of > import_export.h is generic, the second half specific to the qpid-proton > library. > > If in future, additional libraries come into existence, this include file can > be split (or perhaps expanded), without requiring any changes to files > outside of proton-c/include/proton. > > > This addresses bug proton-68. > https://issues.apache.org/jira/browse/proton-68 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/buffer.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/codec.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/cproton.i > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver_extras.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/error.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/framing.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/import_export.h > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/message.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/messenger.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/parser.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/sasl.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/scanner.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/types.h > 1442452 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/util.h > 1442452 > > Diff: https://reviews.apache.org/r/9299/diff/ > > > Testing > ------- > > gcc on linux, and Visual Studio on Windows > > > Thanks, > > Cliff Jansen > >
