> On Feb. 5, 2013, 4:53 p.m., Gordon Sim wrote: > > I'd be tempted to be more direct about this and if we are adding a new > > management property I would have it indicate whether or not the queue is > > replicatable. I.e it would be set false if autodelete && exclusive && > > !args.isSet(AUTO_DELETE_TIMEOUT) and true otherwise. This seems to result > > in a more understandable schema (the point of the declaredExclusive is a > > lot less obvious). > > Alan Conway wrote: > Yes this was an option I considered. I think you're right that it is > better that way. Will code it up... >
I agree with Gordon here - my initial reaction to the addition of a new "declaredExclusive" was 'huh'? I understand now that the 'exclusive' that is published can change, but that's not immediately apparent so the whole naming seems redundant and confusing to read. Since the new flag is visible via mgmt, I'd prefer to see it given a name that is more reflective of it's intended use. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9258/#review16116 ----------------------------------------------------------- On Feb. 5, 2013, 3:33 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9258/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 3:33 p.m.) > > > Review request for qpid, Gordon Sim, Kenneth Giusti, and Ted Ross. > > > Description > ------- > > QPID-4555: HA Add declaredExclusive management property to Queues > > The "exclusive" management property can change over the lifetime of a queue. > This creates race conditions where primary and backup disagree over whether a > queue is replicated. To resolve this, added a new management property > "declaredExclusive" which is set when the queue is created and not modified. > > Do we need to co-ordinate with the Java build over this change to the schema? > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1441163 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1441163 > /trunk/qpid/cpp/src/qpid/broker/QueueRegistry.cpp 1441163 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1441163 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1441163 > /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1441163 > /trunk/qpid/cpp/src/qpid/ha/ReplicationTest.cpp 1441163 > /trunk/qpid/cpp/src/tests/ha_tests.py 1441163 > /trunk/qpid/specs/management-schema.xml 1441163 > > Diff: https://reviews.apache.org/r/9258/diff/ > > > Testing > ------- > > make check > ha tests running 2 hours now without failure. > > > Thanks, > > Alan Conway > >
