----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9404/#review16465 -----------------------------------------------------------
Ship it! trunk/qpid/cpp/src/qpid/broker/Broker.h <https://reviews.apache.org/r/9404/#comment34959> C++ style: Don't use f(void), use f() trunk/qpid/cpp/src/qpid/log/Logger.cpp <https://reviews.apache.org/r/9404/#comment34960> Suggest get/setHiresTimestamp, rather than abbreviation Ts. Consistent with Broker function names. - Alan Conway On Feb. 11, 2013, 11:14 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9404/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2013, 11:14 p.m.) > > > Review request for qpid and Alan Conway. > > > Description > ------- > > This patch adds two management methods to the C++ Broker to get/set the log > hires flag. > > > This addresses bug QPID-4577. > https://issues.apache.org/jira/browse/QPID-4577 > > > Diffs > ----- > > trunk/qpid/cpp/include/qpid/log/Logger.h 1444951 > trunk/qpid/cpp/src/qpid/broker/Broker.h 1444951 > trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1444951 > trunk/qpid/cpp/src/qpid/log/Logger.cpp 1444951 > trunk/qpid/specs/management-schema.xml 1444951 > > Diff: https://reviews.apache.org/r/9404/diff/ > > > Testing > ------- > > It worked at my development station. Unit tests on the way. > > > Thanks, > > Chug Rolke > >
