----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9413/ -----------------------------------------------------------
(Updated Feb. 19, 2013, 3:17 p.m.) Review request for qpid, Kenneth Giusti and Rafael Schloming. Changes ------- Added InteropTest.java, tests both JNI and Native. The test uses a subset of the native Decoder interface. On the native build this is actually a Decoder, on JNI it is a wrapper for codec.Data. Summary (updated) ----------------- PROTON-215: Add type coverage to Java InteropTest. Description (updated) ------- PROTON-215: Add type coverage to Java InteropTest. Covers all types except: - described types, described arrays: not yet done - empty array: throws NPE, possible bug in the decoder. PROTON-215: Fix bug in array decoding discovered by new tests. JNIData.getJavaMap() was alwayws returning an empty map. PROTON-215: Java InteropTest test for primitve types. Added Java test coverage for just the primitive types, more types coming soon. PROTON-215: Interop test: make finding AMQP fragments more robust. Python: find the interop fragments by walking up the directory tree from __file__. Java: Copy AMQP fragments as resources. git-svn-id: https://svn.apache.org/repos/asf/qpid/proton/trunk@1446307 13f79535-47bb-0310-9956-ffa450edef68 Diffs (updated) ----- /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/TestDecoder.java PRE-CREATION /proton/trunk/proton-c/bindings/java/src/main/java/org/apache/qpid/proton/codec/jni/JNIData.java 1447222 /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/TestDecoder.java PRE-CREATION /proton/trunk/tests/interop/message.amqp UNKNOWN /proton/trunk/tests/java/org/apache/qpid/proton/InteropTest.java PRE-CREATION /proton/trunk/tests/python/interop-generate 1447222 /proton/trunk/tests/python/proton_tests/interop.py 1447222 Diff: https://reviews.apache.org/r/9413/diff/ Testing ------- described_array test fails, skipping. I believe the tests have found their first bug :) Thanks, Alan Conway
