----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9516/#review16749 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Feb. 19, 2013, 9:16 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9516/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 9:16 p.m.) > > > Review request for qpid, Kenneth Giusti and Rafael Schloming. > > > Description > ------- > > PROTON-232: described arrays seem to force the descriptor to be of the same > type as the array > > Fixed bug in code.c pn_data_encode_node: was always using the parent->type > for everything inside an array, including the descriptor. > > > Diffs > ----- > > /proton/trunk/proton-c/src/codec/codec.c 1447222 > /proton/trunk/tests/interop/described_array.amqp UNKNOWN > /proton/trunk/tests/python/proton_tests/interop.py 1447222 > > Diff: https://reviews.apache.org/r/9516/diff/ > > > Testing > ------- > > jni, java-native and python tests all pass. New test case added in interop.py > > > Thanks, > > Alan Conway > >
