[ 
https://issues.apache.org/jira/browse/QPID-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589657#comment-13589657
 ] 

Alex Rudyy commented on QPID-4608:
----------------------------------

Hi Rajith,

I would like to point out that your commit http://svn.apache.org/r1451047 
changed the exception handling in AMQSession#createTemporaryQueue().
{code:java}
@@ -1434,12 +1432,9 @@
                     new FieldTable(), result.getExchangeName(), result);
             return result;
         }
-        catch (Exception e)
+        catch (AMQException e)
         {
-           JMSException jmse = new JMSException("Cannot create temporary 
queue");
-           jmse.setLinkedException(e);
-           jmse.initCause(e);
-           throw jmse;
+           throw toJMSException("Cannot create temporary queue",e);
         }
     }
 
{code}

This method can potentially throw FailoverException and runtime exceptions like 
TransportException etc. IMHO, this changes the behaviour of the client. I would 
like to suggest to add code to re-throw theses exceptions as JMSException as it 
used to be.
                
> JMS client authorization failure throws JMSException instead of 
> JMSSecurityException
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-4608
>                 URL: https://issues.apache.org/jira/browse/QPID-4608
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.18, 0.20
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>            Priority: Minor
>              Labels: jms, jmsexception
>             Fix For: 0.21
>
>
> When ACLs doen't authorize a user to perform an action, Java client raises 
> JMSException while JMSSecurityException should be raised.
> From the java docs for JMSSecurityException,
> "This exception must be thrown when a provider rejects a user name/password 
> submitted by a client. It may also be thrown for any case where a security 
> restriction prevents a method from completing."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to