-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9824/
-----------------------------------------------------------
Review request for qpid.
Description
-------
Change the queue-depth threshold alerts to be edge-triggered rather than
level-sensitive. Provide upper and lower thresholds for both message count and
byte count. Two events are generated: "Crossing-Upward" events are raised
when the upper threshold is crossed lower-to-higher and "Crossing-Downward"
events are raised when the lower threshold is crossed higher-to-lower.
This removes the need for a mechanism to throttle events and it also removes
the need for special handling for recursion (thresholds-on-the-event-queue).
If the lower thresholds are not specified or invalid, they are set to half of
the upper threshold.
This addresses bug QPID-4632.
https://issues.apache.org/jira/browse/QPID-4632
Diffs
-----
trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1454413
trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1454413
trunk/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1454413
trunk/qpid/cpp/src/qpid/broker/ThresholdAlerts.cpp 1454413
trunk/qpid/specs/management-schema.xml 1454413
trunk/qpid/tests/src/py/qpid_tests/broker_0_10/threshold.py 1454413
Diff: https://reviews.apache.org/r/9824/diff/
Testing
-------
The existing tests were modified and a new test for threshold hysteresis was
added.
Thanks,
Ted Ross
