-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9855/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Description
-------

This change mostly adds a simple reader for the application-properties section 
of messages which simply hands on the values to a passed in MapHandler. This is 
sufficient to make processProperties() work for simple scalar properties (and 
we don't actually use it for anything else anyway).

Part of this change eliminates the MapHandler::CharSequence type in favour of 
the qpid::amqp::CharSequence type which is nearly identical (but a bit more 
fleshed out). This has been done by making the eliminated type a typedef to the 
replacement type, this isn't sufficient by itself but makes the necessary code 
changes much shorter.


This addresses bug QPID-4625.
    https://issues.apache.org/jira/browse/QPID-4625


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp 1455153 
  /trunk/qpid/cpp/src/qpid/broker/MapHandler.h 1455153 
  /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1455153 
  /trunk/qpid/cpp/src/qpid/broker/amqp/Message.cpp 1455153 
  /trunk/qpid/cpp/src/qpid/broker/amqp_0_10/MessageTransfer.cpp 1455153 
  /trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1455153 

Diff: https://reviews.apache.org/r/9855/diff/


Testing
-------

cmake:
make test


Thanks,

Andrew Stitcher

Reply via email to