I've never personally needed to set M2_HOME (I think it just defaults to $HOME/.m2) so I think removing this dependency from the cmake build should be fine.
I shall refrain from making a comment on whether any installation of maven can possibly be considered sane ;-) -- Rob On 14 March 2013 18:32, Cliff Jansen <[email protected]> wrote: > I am guilty for its inclusion and can't find a specific reason (from > memory, or trying to force a failure) for its need. > > Note that there is no FindMaven.cmake equivalent available, so I > cooked up a heuristic. I relied on maven being in the PATH. Also, > based on my unfamiliarity with maven, I think I just read the install > instructions to require M2_HOME being set on all platforms as well to > signify a sane maven install. > > I have no objection to its removal if it works on your systems. I'll > adjust to taste if things fail on windows (won't know until I can > actually build the java bits... still a work in progress) > > Cliff > > On Thu, Mar 14, 2013 at 12:20 PM, Alan Conway <[email protected]> wrote: >> It's required by the proton CMakeLists.txt to run the JNI tests, but I can >> run them without this variable set no problem. I'd like to remove the >> requirement unless there's a good reason for it. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
