----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9947/ -----------------------------------------------------------
Review request for qpid, Andrew Stitcher and Gordon Sim. Description ------- Proposed patch from Pavel Moravec from bz 919017 (https://bugzilla.redhat.com/show_bug.cgi?id=919017) >From the bz: """ Description of problem: If no binding key for a XML exchange matches the routing key of incoming message, then QMF statistics of the exchange are not updated - while msgIn, msgDrop, byteIn and byteDrop should be updated. Additional info: This BZ assumes XML exchange runs xquery only for the bindings with binding key matching routing key of the message being processed - something I dont see a reason for, as the xquery should decide alone if the binding matches or not. If bindingsMap[routingKey].snapshot() is null, dont return XmlExchange::route() immediatelly but let call doRoute(msg, b); for empty BindingList b - it will just count the stats. Not sure if RWlock::ScopedRlock l(lock); makes further sense now, though. """ Diffs ----- trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1454425 Diff: https://reviews.apache.org/r/9947/diff/ Testing ------- - verified problem before patch - applied patch, compiled, modified patch to correctly compile - noted change in statistics Thanks, Ernie Allen
