Personally I would probably go for option 2, though I see the existing comparison (presumably for the old BindingURLs) was already similarly lacking.
At the very least I think the comment Alex made on the JIRA around the 'subject' from the Address string needs to be addressed. I seem to recall from reviewing a different change at some point, I noted that not specifying an exchange within an Address made it default to use of the amq.topic exchange somewhere under the covers. That suggests that after the change which has been made, for many users session.createTopic(<simple topic name>) could have unexpectedly started returning a lot of different Topic objects that always say they are equal when they are clearly not expected to be. Robbie On 11 March 2013 21:04, Rajith Attapattu <rajit...@gmail.com> wrote: > Hi All, > > While fixing QPID-3769, I came across this issue. > > There are two options for implementing the equals method (and hashcode). > > 1. Check the "type" and "name" to ensure they both point to the same > "destination" (which could be a queue or an exchange in pre 1.0 > terms). > > 2. Do a comprehensive check on the internal address data structure to > ensure that all fields, properties, options are the same. > > (Please note that comparing two address strings is not a good idea as > there can whitespaces). > > I prefer option one and have pasted the patch as a comment on the JIRA > > What do others think? > > Regards, > > Rajith > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
