-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10076/
-----------------------------------------------------------
Review request for qpid and Keith Wall.
Description
-------
More for proton-254.
Of note is the mechanism proton-c/bindings/java/checkmatch.py to ensure that
any changes to codec.h will cause a build failure if they aren't also included
in the corresponding java.i file. All proposed solutions on the list thus far
have not been particularly elegant. This attempts to address the main drawback
of this apporach (the two files getting out of sync).
I suspect that the solution for other swig languages will at least differ on
the %extend pn_atom_t {} section. I would prefer to defer a more generalized
solution (if any) until another example pops up.
The pieces all build, but ctest fails and I cannot get the equivalent to start
running from the command line, so I can't work backwards to a better cmake
build. By hand I must
- cp ./build/proton-c/bindings/java/proton-jni-0.4.jar
./build/proton-c/bindings/java/proton-jni.jar
- resolve PATH for finding maven in ctest (may not be an issue if set
globally).
Even after this, the maven test fails with
java.util.ServiceConfigurationError: org.apache.qpid.proton.codec.DataFactory:
Provider org.apache.qpid.proton.codec.jni.JNIDataFactory could not be
instantiated: java.lang.UnsatisfiedLinkError: no proton-jni in java.library.path
I'm not sure where to point fingers (the maven pom, the built files). I will
attempt a simple java test outside of maven to see if that works.
This addresses bug proton-254.
https://issues.apache.org/jira/browse/proton-254
Diffs
-----
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/java/CMakeLists.txt
1459606
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/java/checkmatch.py
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/java/java.i
1459606
http://svn.apache.org/repos/asf/qpid/proton/trunk/tools/cmake/Modules/ProtonUseJavaSourceFileList.cmake
1459606
Diff: https://reviews.apache.org/r/10076/diff/
Testing
-------
rhel 6 and windows 8
Thanks,
Cliff Jansen
