[ 
https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reopened QPID-3769:
----------------------------------


Reopening for a couple reasons.

Half the changes were committed before the 0.22 branch, and half after. The 
remainder need to be requested for merge if they check out ok. We should then 
assign the fix-version appropriately.

I think this needs more tests to ensure the changes check out ok:

In the test that exists, some bits use AMQTopic destination objects, and that 
has its own equals() implementation and so isn't really affected by these 
changes.

There doesn't seem to be any testing using AMQAnyDestination, which gets used 
for all the Address syntax based destinations created via JNDI and so is 
affected by these changes.

                
> NPE in client AMQDestination.equals()
> -------------------------------------
>
>                 Key: QPID-3769
>                 URL: https://issues.apache.org/jira/browse/QPID-3769
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.12
>            Reporter: Jan Bareš
>            Assignee: Rajith Attapattu
>              Labels: addressing
>
> Code of org.apache.qpid.client.AMQDestination.equals(Object) is buggy, it 
> should test for null on _exchangeClass and _exchangeName before dereferencing 
> them, lines 522 and 526.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to