----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10155/#review18424 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/xml/XmlExchange.h <https://reviews.apache.org/r/10155/#comment38631> Good point. Moving new function to private. - Chug Rolke On March 27, 2013, 2:38 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10155/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 2:38 p.m.) > > > Review request for qpid, Alan Conway, Gordon Sim, and Kenneth Giusti. > > > Description > ------- > > Self test federation.test_dynamic_topic hangs. Two threads take out an Rlock > and then try to upgrade the lock to a Wlock and hang. > > The failure was intermittent. Only automake builds running 'make check' > seemed to have the issue. > > The fix is to create an unbindLH() function that does the unbind but does not > take out the Wlock itself. > > The note in the Jira about similar behavior in the TopicExchange is wrong; > this issue is XmlExchange only. > > > This addresses bug QPID-4672. > https://issues.apache.org/jira/browse/QPID-4672 > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/xml/XmlExchange.h 1461592 > trunk/qpid/cpp/src/qpid/xml/XmlExchange.cpp 1461592 > > Diff: https://reviews.apache.org/r/10155/diff/ > > > Testing > ------- > > Passes automake and cmake tests. > > > Thanks, > > Chug Rolke > >
