----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9903/#review18460 -----------------------------------------------------------
Ship it! Looks good to me. I highlighted a few TODOs in the code, not because they're showstoppers for me, but to check you're actually intending to commit them :-) /proton/trunk/tests/python/proton_tests/soak.py <https://reviews.apache.org/r/9903/#comment38683> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. /proton/trunk/tests/python/proton_tests/soak.py <https://reviews.apache.org/r/9903/#comment38684> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. /proton/trunk/tests/tools/apps/c/msgr-recv.c <https://reviews.apache.org/r/9903/#comment38685> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. /proton/trunk/tests/tools/apps/c/msgr-recv.c <https://reviews.apache.org/r/9903/#comment38686> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. /proton/trunk/tests/tools/apps/c/msgr-send.c <https://reviews.apache.org/r/9903/#comment38687> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. /proton/trunk/tests/tools/apps/c/msgr-send.c <https://reviews.apache.org/r/9903/#comment38688> I'm not dead-set against committing code containing TODO's but just wanted to check that you're not leaving this in accidentally. - Philip Harvey On March 25, 2013, 9:39 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9903/ > ----------------------------------------------------------- > > (Updated March 25, 2013, 9:39 p.m.) > > > Review request for qpid, Rafael Schloming, Justin Ross, and Philip Harvey. > > > Description > ------- > > This patch puts the infrastructure in place for system and soak tests as > described in proton-223. > > In summary: > > o) it adds a set of simple messenger-based applications for sending a > receiving messages; implementations done in python and C (for now). > o) creates a set of python test scripts for driving these tests > > Right now I've got a small set of tests that generate traffic between the > applications and verify that no messages are dropped. These are run as part > of "ctest", or can be run directly using the python test tool: > > ./test/python/proton-test -m system_tests > > > Todo: > > 1) I need a Java-based version of the Messenger apps. Other languages are > desired too, but we need Java for coverage of that implementation. > 2) Enhance the receivers to explicitly accept messages based on window size. > 3) More tests - connection scale, link scale, a test that covers proton-131, > long running traffic tests, etc > 4) Benchmark tests and related support for gathering throughput and latency. > 5) Valgrind coverage exists for the C application, but fails for any cross > language tests. A small set of C-only tests would be useful for valgrind > tests. > 6) anything else??? > > > This addresses bugs proton-131 and proton-223. > https://issues.apache.org/jira/browse/proton-131 > https://issues.apache.org/jira/browse/proton-223 > > > Diffs > ----- > > /proton/trunk/CMakeLists.txt 1457783 > /proton/trunk/config.sh 1457783 > /proton/trunk/proton-c/CMakeLists.txt 1457783 > /proton/trunk/proton-c/src/ssl/openssl.c 1457783 > /proton/trunk/tests/python/proton_tests/__init__.py 1457783 > /proton/trunk/tests/python/proton_tests/common.py 1457783 > /proton/trunk/tests/python/proton_tests/soak.py PRE-CREATION > /proton/trunk/tests/python/proton_tests/valgrind.supp PRE-CREATION > /proton/trunk/tests/tools/apps/README.txt PRE-CREATION > /proton/trunk/tests/tools/apps/c/CMakeLists.txt PRE-CREATION > /proton/trunk/tests/tools/apps/c/msgr-common.h PRE-CREATION > /proton/trunk/tests/tools/apps/c/msgr-common.c PRE-CREATION > /proton/trunk/tests/tools/apps/c/msgr-recv.c PRE-CREATION > /proton/trunk/tests/tools/apps/c/msgr-send.c PRE-CREATION > /proton/trunk/tests/tools/apps/python/msgr-recv.py PRE-CREATION > /proton/trunk/tests/tools/apps/python/msgr-send.py PRE-CREATION > /proton/trunk/tests/tools/soak-check PRE-CREATION > > Diff: https://reviews.apache.org/r/9903/diff/ > > > Testing > ------- > > The short tests have been added to ctest, only tested on Linux (fedora 17) > thus far. > > > Thanks, > > Kenneth Giusti > >
