----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10173/ -----------------------------------------------------------
Review request for qpid and Chug Rolke. Description ------- When broker.deleteQueue is explicitly called, acl->recordDestroyQueue is called to decrement the acl queue counter for that user. However, auto delete queues are deleted in Queue::tryAutoDeleteImpl which was not calling acl->recordDestroyQueue. This patch just checks to see if acls are loaded and calls acl->recordDestroyQueue when an auto delete queue is deleted. Diffs ----- trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1457042 Diff: https://reviews.apache.org/r/10173/diff/ Testing ------- started broker with --max-queues-per-user 10 created 10 auto delete queues (q1 - q10) and sent a message to each tried to create another queue (q11) -> failed deleted auto delete queue (using drain -c 0 q1) before patch: tried to create another queue (q12) -> failed after patch: tried to create another queue (q12) -> success tried to create another queue (q13) -> failed started broker without acl verified that I could create and delete a large number of auto delete queues Thanks, Ernie Allen
