[
https://issues.apache.org/jira/browse/QPID-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618764#comment-13618764
]
Rob Godfrey commented on QPID-4682:
-----------------------------------
General question: I see no changes to documentation here... does this mean that
the command line options were previously undocumented (since we have changed
them)? If not, obviously the docs should be updated... if they were we should
raise a JIRA to document them (although I guess this could be done after 0.22,
as the situation would be no worse than currently).
Completely trivial nitpick:
{code:title=Main.java}
if (quiesceVhosts)
{
options.setManagementModeQuiesceVirtualHosts(true);
}
{code}
any reason for not just
options.setManagementModeQuiesceVirtualHosts(quiesceVhosts); ?
Happy for this to go into 0.22 as long as it doesn't led to incorrect
documentation in the release (if it does we should include a patch for the docs
too).
> [Java Broker] QPID-4594 review changes
> --------------------------------------
>
> Key: QPID-4682
> URL: https://issues.apache.org/jira/browse/QPID-4682
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.21
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.23
>
>
> QPID-4594 review changes
> The original commits were part of the 0.22 release branch, the review changes
> are being made on trunk/0.23 and will be requested for inclusion in 0.22.
> This is a secondary holder JIRA for the changes in case they should remain
> assigned to 0.23/0.24.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
