[
https://issues.apache.org/jira/browse/QPID-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618771#comment-13618771
]
Rob Godfrey commented on QPID-4683:
-----------------------------------
Looks good... a couple of trivial typos/spelling errors. Wouldn't really
consider any as blockers for a merge to 0.22
{code:title=PortFactory.java}
// Can't or Cannot (not Cant) :-) - this is repeated a couple of lines later
throw new IllegalConfigurationException("Cant create port which requests SSL
client certificates as the broker has no trust/peer stores configured.");
// surely we can omit the first half of this test - it can't be a performance
critical piece of code :)
boolean doesntUseSSL = port.getTransports().isEmpty() ||
!port.getTransports().contains(Transport.SSL);
// already exists not exist.
throw new IllegalConfigurationException("Port for protocol " + protocol + "
already exist. Only one management port per protocol can be created");
{code}
{code:title=PortFactoryTest.java}
// Too many s's (Sssl)
public void testCreateAmqpPortUsingSsslSucceedsWithKeyStore()
{code}
> [Java Broker] QPID-4657 review changes
> --------------------------------------
>
> Key: QPID-4683
> URL: https://issues.apache.org/jira/browse/QPID-4683
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.21
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.23
>
>
> QPID-4657 review changes
> The original commits were part of the 0.22 release branch, the review changes
> are being made on trunk/0.23 and will be requested for inclusion in 0.22.
> This is a secondary holder JIRA for the changes in case they should remain
> assigned to 0.23/0.24.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
