Robbie Gemmell created QPID-4696:
------------------------------------
Summary: [Java Broker] QPID-4461 review changes
Key: QPID-4696
URL: https://issues.apache.org/jira/browse/QPID-4696
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.21
Reporter: Robbie Gemmell
Assignee: Alex Rudyy
Fix For: 0.23
JIRA to perfom review changes from QPID-4661. The initial changes are already
on the 0.22 branch, whereas these are currently going to go on trunk/0.23.
Creating new JRIA as a holder in case they remain in 0.23/0.24 only.
# On the attribute editing screen, the attributes are scattered in a completely
different order than the viewing screen. Should probably be grouped similarly
to the viewing screen.
# We should show the units of the setting (where appropriate) as part of its
'pretty printing' text.
# I think we can now remove GroupPrincipalAccessor now that it is being created
all the time and not up-front, it is just holding a collection and then being
thrown away, i.e not doing anything useful.
# We should be able to set the flow control attributes independently of each
other, it is not required that you change both at the same time. The only
restriction is that the flow control size can’t be less than the flow resume
size.
# DEFAULT_GROUP_PROFIDER_NAME typo
# Dont these changes all occur on the config thread? If so we shouldn't need to
comment on thread safety as there is only one thread involved.
BrokerAdapter: "// the calls below are not thread safe but they should
be fine in a management mode"
SecurityManager:
"// the code below is not thread safe, however, it should be fine in a
management mode
+ // as there will be no user connected"
# This isn't particularly safe since it removes the old stuff before putting
the new stuff in place, leaving a gap.
{code}
+ if (oldAttributeValue != null)
+ {
+ List<String> pluginNames =
_aclConfigurationToPluginNamesMapping.remove(oldAttributeValue);
+ if (pluginNames != null)
+ {
+ for (String name : pluginNames)
+ {
+ _hostPlugins.remove(name);
+ }
+ }
+ }
+ if (newAttributeValue != null)
+ {
+ configureACLPlugin((String)newAttributeValue);
+ }
+ _immediatePublishPropsCache.clear();
+ _publishPropsCache.clear();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
