----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10299/#review18697 -----------------------------------------------------------
There is no flag-ordering code in the diff, I think it's from a different issue (missing nss libraries). - Alan Conway On April 5, 2013, 1:14 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10299/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 1:14 p.m.) > > > Review request for qpid, Andrew Stitcher, Alan Conway, Steve Huston, and Rob > Godfrey. > > > Description > ------- > > The problem is that when the --as-needed flag is used with the linker (the > default for recent versions of ubuntu), libraries must follow any .o file > that needs them or they get ignored as not needed. At present the libraries > are included before the .o files. This is an update to the initial patch that > avoids the duplicated libraries on the link command line. > > > This addresses bug QPID-4702. > https://issues.apache.org/jira/browse/QPID-4702 > > > Diffs > ----- > > /trunk/qpid/cpp/src/ssl.cmake 1464148 > > Diff: https://reviews.apache.org/r/10299/diff/ > > > Testing > ------- > > make test > > > Thanks, > > Gordon Sim > >