-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10373/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Robbie Gemmell, and Fraser Adams.
Description
-------
This patch modifies the Federation Bridge configuration API to provide the
ability to configure the credit used on the underlying subscription.
Currently, users are not allowed to configure credit - it defaults to
unlimited. That is, unless '--ack' is enabled on the bridge - in that case,
credit is forced to 2 * N (where N is the --ack parameter).
This patch allows for more granularity when configuring the Bridge, plus
removes the 2 * N convention as this can cause problems in those deployments
that cannot backpressure effectively (old async queue replication).
So, this change -does- change the existing behavior when --ack is used, but I'd
argue that the old behavior is not necessarily correct.
Since this changed the management schema, I assume this may affect the Java
broker in some way. But I've not been able to find any problems - Java build
and tests clean - so please let me know if I've missed anything.
This addresses bug qpid-4728.
https://issues.apache.org/jira/browse/qpid-4728
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1465459
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1465459
/trunk/qpid/cpp/src/qpid/broker/Link.cpp 1465459
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h 1465459
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1465459
/trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1465459
/trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1465459
/trunk/qpid/cpp/src/tests/federation.py 1465459
/trunk/qpid/cpp/src/tests/federation_sys.py 1465459
/trunk/qpid/specs/management-schema.xml 1465459
/trunk/qpid/tools/src/py/qpid-route 1465459
Diff: https://reviews.apache.org/r/10373/diff/
Testing
-------
unit test added.
Thanks,
Kenneth Giusti
