----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10348/#review18846 -----------------------------------------------------------
Ship it! While I agree with Andrew that getting a good RPM/DEB/MSI installer from the cmake is probably not a worthy goal, it is important to get the install part working simply because it can be used to support the installers. For example, the Windows packager uses the cmake install step to stage the needed files since it knows the complete set of files. So, incremental changes such as this one to support that is a Good Thing. - Steve Huston On April 8, 2013, 9:53 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10348/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 9:53 p.m.) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Description > ------- > > Get cmake package working. > > "make package" currently is broken, it gives lots of errors like: > > CMake Error at > /home/aconway/qpid/build/bindings/qpid/python/cmake_install.cmake:70 (FILE): > file INSTALL cannot copy file > "/home/aconway/qpid/build/bindings/qpid/python/_cqpid_python.so" to > "/usr/local/lib64/python2.7/site-packages/_cqpid.so". > Call Stack (most recent call first): > /home/aconway/qpid/build/bindings/cmake_install.cmake:37 (INCLUDE) > /home/aconway/qpid/build/cmake_install.cmake:63 (INCLUDE) > > Look at the comments in the diff, they explain what I've figured out so far. > > > Diffs > ----- > > /trunk/qpid/cpp/BuildInstallSettings.cmake 1465590 > /trunk/qpid/cpp/bindings/CMakeLists.txt 1465590 > > Diff: https://reviews.apache.org/r/10348/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
