----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10398/#review18974 -----------------------------------------------------------
Ship it! It should be rebased on the latest tip. But otherwise it's good to go. - Darryl Pierce On April 10, 2013, 5:33 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10398/ > ----------------------------------------------------------- > > (Updated April 10, 2013, 5:33 p.m.) > > > Review request for qpid and Darryl Pierce. > > > Description > ------- > > QPID-4733: Fix cmake installation of init scripts > > - Install both qpidd and qpidd-primary init scripts. > - Fix path substitution to use absolute paths. > - Fix substitution to work on cmake and automake. > - Set executable permissions for init scripts. > > > Diffs > ----- > > /trunk/qpid/cpp/etc/CMakeLists.txt 1466169 > /trunk/qpid/cpp/etc/Makefile.am 1466169 > /trunk/qpid/cpp/etc/qpidd-primary.in 1466169 > /trunk/qpid/cpp/etc/qpidd.in 1466169 > > Diff: https://reviews.apache.org/r/10398/diff/ > > > Testing > ------- > > make intstall, verify init scripts work. > > > Thanks, > > Alan Conway > >
