-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10704/
-----------------------------------------------------------
Review request for qpid and Alan Conway.
Description
-------
The changes involve:
(1) removing the unnecessary lock from ReceiverImpl::getName() since the
destination member variable is const
(2) removing the lock from the two forms of SessionImpl:acknowledgeImpl() since
the transactional member is const and IncomingMessages::accept() does its own
locking
(3) releasing the lock while calling back from ReceiverImpl to SessionImpl in
ReceiverImpl::close()
These help break the possible deadlock.
This addresses bug QPID-4764.
https://issues.apache.org/jira/browse/QPID-4764
Diffs
-----
/trunk/qpid/cpp/src/qpid/client/amqp0_10/ReceiverImpl.cpp 1470466
/trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1470466
Diff: https://reviews.apache.org/r/10704/diff/
Testing
-------
make check passes (I couldn't reproduce the deadlock).
Thanks,
Gordon Sim
