----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10686/#review19545 -----------------------------------------------------------
Sorry for the delayed response, you picked possibly the second time this year both Rob and I were otherwise occupied over the weekend and beyond :) Looking this over it seems like it would work, but I can't say I am a big fan of inspecting potentially every connection during every consumer creation and removal. An alternative might be: the SessionModel interface has a method to get the associated ConnectionModel, with which you could directly query for the associated Connection[Adapter] from the Virtualhost since it already maintains that mapping. http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/QueueAdapter.java <https://reviews.apache.org/r/10686/#comment40348> Marking for reference http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/QueueAdapter.java <https://reviews.apache.org/r/10686/#comment40349> Marking for reference - Robbie Gemmell On April 20, 2013, 6:59 p.m., Fraser Adams wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10686/ > ----------------------------------------------------------- > > (Updated April 20, 2013, 6:59 p.m.) > > > Review request for qpid, Gordon Sim, Robbie Gemmell, and Rob Godfrey. > > > Description > ------- > > In the management model it should be possible to navigate from a Connection > through its associated Sessions to Queues via Subscriptions/Consumers. > > Basically Subscription is an association class linking Session and Queue. > > In the Java Broker Management Model there was code missing that should allow > the SessionAdapter to getSubscriptions(). > > This patch provides code to do the necessary object registrations to allow > the Subscriptions in SessionAdapter to be correctly maintained thus allowing > navigation from Connection to Queue and vice versa. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConnectionAdapter.java > 1469902 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/ConsumerAdapter.java > 1469902 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/QueueAdapter.java > 1469902 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/SessionAdapter.java > 1469902 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/model/adapter/VirtualHostAdapter.java > 1469902 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/tools/src/java/src/qpid-broker-plugins-management-qmf2/java/org/apache/qpid/server/qmf2/QmfManagementAgent.java > 1469902 > > Diff: https://reviews.apache.org/r/10686/diff/ > > > Testing > ------- > > I've tested in the QmfManagementPlugin. Plugin loaded and the QMF Gui was > able to navigate starting from a Connection through Subscribed Sessions to > Queue. Also Started with Queue and navigated through Subscriptions to show > Session info and navigate to Connection. > > > Thanks, > > Fraser Adams > >
