----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10376/#review19856 -----------------------------------------------------------
My comments (sorry for later review): - it is not stated what ha-* broker options are mandatory and what are optional. - `link-*-interval` options are valid for inter-broker links, I guess (but not evident from the description). I suggest changing: - "to check link health" to "to check inter-broker management/failover/whatever-fits-best link health", and - "for replication links" to "for inter-broker replication links" (both in README-HA.txt and the xml file) - cluster.conf example has VIP 20.0.20.200 while further 20.0.10.200 is used (e.g. ha-public-url and in text) - MECH vs. MECHANISM: compare lines 302 and 797 of the xml - Pavel Moravec On April 11, 2013, 4:04 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10376/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 4:04 p.m.) > > > Review request for qpid, Andy Goldstein, Jason Dillaman, mick goulish, Pavel > Moravec, and Justin Ross. > > > Description > ------- > > NO-JIRA: HA updates to migration guide. > > git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1466933 > 13f79535-47bb-0310-9956-ffa450edef68 > > > Diffs > ----- > > /trunk/qpid/cpp/README-HA.txt 1466895 > /trunk/qpid/doc/book/src/cpp-broker/Active-Passive-Cluster.xml 1466895 > > Diff: https://reviews.apache.org/r/10376/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
