> On April 30, 2013, 5:07 p.m., Steve Huston wrote: > > Ship It!
Aside from the trailing whitespace on lines 56 and 121. Thank you for working this issue out - I knew there was something off in the binary but never worked out what it could be. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10863/#review19958 ----------------------------------------------------------- On April 30, 2013, 5:03 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10863/ > ----------------------------------------------------------- > > (Updated April 30, 2013, 5:03 p.m.) > > > Review request for qpid, Chug Rolke and Steve Huston. > > > Description > ------- > > This fix makes explicit when GUIDs are in play. It asssumes that all values > passed in from and back to the lower layer are UUIDs. It converts between > the two binary formats as necessary. > > > This addresses bug qpid-4792. > https://issues.apache.org/jira/browse/qpid-4792 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/uuid.cpp > 1477707 > > Diff: https://reviews.apache.org/r/10863/diff/ > > > Testing > ------- > > Windows, uuids received from and sent to Linux, spout drain > > > Thanks, > > Cliff Jansen > >
