----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11628/#review21581 -----------------------------------------------------------
Ship it! Ship It! - Kenneth Giusti On June 6, 2013, 3:40 p.m., Andrew Stitcher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11628/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 3:40 p.m.) > > > Review request for qpid, Alan Conway, Gordon Sim, Kenneth Giusti, and Ted > Ross. > > > Description > ------- > > A bunch of tidy ups to the C++ qpid code see the JIRA for a more detailed > breakdown. > > Change 1. - Remove unused members in Connector interface. > > > This addresses bug QPID-4905. > https://issues.apache.org/jira/browse/QPID-4905 > > > Diffs > ----- > > /trunk/qpid/cpp/src/CMakeLists.txt 1489458 > /trunk/qpid/cpp/src/Makefile.am 1489458 > /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.h 1489458 > /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/Bridge.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/Connection.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/ConnectionState.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1489458 > /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1489458 > /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1489458 > /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.h 1489458 > /trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp 1489458 > /trunk/qpid/cpp/src/qpid/client/Connector.h 1489458 > /trunk/qpid/cpp/src/qpid/client/RdmaConnector.cpp 1489458 > /trunk/qpid/cpp/src/qpid/client/SslConnector.cpp 1489458 > /trunk/qpid/cpp/src/qpid/client/TCPConnector.h 1489458 > /trunk/qpid/cpp/src/qpid/client/TCPConnector.cpp 1489458 > /trunk/qpid/cpp/src/qpid/framing/OutputHandler.h 1489458 > /trunk/qpid/cpp/src/qpid/framing/amqp_framing.h 1489458 > /trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.cpp 1489458 > /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1489458 > /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1489458 > /trunk/qpid/cpp/src/qpid/sys/ConnectionInputHandler.h 1489458 > /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandler.h 1489458 > /trunk/qpid/cpp/src/qpid/sys/ConnectionOutputHandlerPtr.h 1489458 > /trunk/qpid/cpp/src/qpid/sys/TimeoutHandler.h 1489458 > > Diff: https://reviews.apache.org/r/11628/diff/ > > > Testing > ------- > > cmake: make ; make test. > autotools: make ; make check > > Simple heartbeat test: > - Run qpid-receive -f against qpidd; > - Stop qpidd - see that qpid-receive disconnects after heartbeat interval > - Restart qpidd > - Start new qpid-receive -f > - Stop qpid-receive - see that qpidd disconnects after heartbeat interval > > > Thanks, > > Andrew Stitcher > >
