Hi Gordon,
I'm afraid that I've *still* not got around to messing with proton/AMQP
1.0 (sorry, I've been tied in knots with various other things) so I
won't be able to do the sort of review this really deserves.
Firstly though thanks for doing this, I think that being able to provide
this sort of configuration fixes a real limitation on queues
"automagically" created under the hood (does this work with
static/dynamic "exchange" routes too?).
I notice that you've also done some work with respect to the headers
exchange x-binding stuff we discussed a little while back and similar
for xquery/xml exchange.
All of that is fantastic, so thanks very much. I don't suppose that
you'd be able to post syntax examples for all of these to the user list
(don't know if you've been able to update things like the Programming in
Apache Qpid book?). My headers bindings tend to follow a pattern similar
to below:
"testqueue; {create: receiver, node: {x-declare: {arguments:
{'qpid.policy_type': ring, 'qpid.max_size': 500000000}}, x-bindings:
[{exchange: 'amq.match', queue: 'testqueue', key: 'data1', arguments:
{x-match: all, data-service: amqp-delivery, item-owner: fadams}}]}}"
TBH it took a bit of trial and error to figure out the headers binding
syntax at all (sometimes still seems a bit of a black art) so perhaps
the most constructive review comment that I can come up with is that
plenty of example address strings and other config. for various use
cases (including the new shared topic subscription if it needs any
special syntax) would be *really* useful.
Thanks again for this - and sorry again I can't yet do it justice.
Regards,
Frase
On 12/06/13 19:09, Gordon Sim wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11840/
-----------------------------------------------------------
Review request for qpid, Ted Ross and Fraser Adams.
Description
-------
The approach here is to allow a topic node to be defined at the broker level
(though only seen by AMQP 1.0 connections) that encompasses a given exchange
and queue configuration information to be used with all subscription queues
created for outgoing links from that node. You can have different topics mapped
(with different names) to the same exchange, allowing different sets of policy
to be applied.
This addresses bug QPID-4919.
https://issues.apache.org/jira/browse/QPID-4919
Diffs
-----
/trunk/qpid/cpp/src/Makefile.am 1492311
/trunk/qpid/cpp/src/amqp.cmake 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.h PRE-CREATION
/trunk/qpid/cpp/src/qpid/broker/amqp/BrokerContext.cpp PRE-CREATION
/trunk/qpid/cpp/src/qpid/broker/amqp/Connection.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Domain.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Domain.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Interconnect.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Interconnect.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Interconnects.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Interconnects.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/ProtocolPlugin.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Sasl.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Sasl.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1492311
/trunk/qpid/cpp/src/qpid/broker/amqp/Topic.h PRE-CREATION
/trunk/qpid/cpp/src/qpid/broker/amqp/Topic.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/11840/diff/
Testing
-------
make check passes, basic test of new behaviour works as expected
Thanks,
Gordon Sim
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
