----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11915/#review22057 -----------------------------------------------------------
Ship it! /trunk/qpid/cpp/src/tests/brokertest.py <https://reviews.apache.org/r/11915/#comment45404> If you add the option here then it should be removed from interlink_tests.py - I left it out from here in case there were tests like the ha ones that didn't want it, but I'm perfectly happy for it to be a general option (just don't want the interlink tests to break as a result). - Gordon Sim On June 17, 2013, 8:23 p.m., Andrew Stitcher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11915/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 8:23 p.m.) > > > Review request for qpid, Alan Conway and Gordon Sim. > > > Description > ------- > > See QPID-4931 for full rationale > > > This addresses bug QPID-4931. > https://issues.apache.org/jira/browse/QPID-4931 > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/windows/SslProtocolFactory.cpp 1493903 > /trunk/qpid/cpp/src/qpid/sys/SocketAddress.h 1493903 > /trunk/qpid/cpp/src/qpid/sys/SocketTransport.h 1493903 > /trunk/qpid/cpp/src/qpid/sys/SocketTransport.cpp 1493903 > /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1493903 > /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1493903 > /trunk/qpid/cpp/src/qpid/sys/posix/SocketAddress.cpp 1493903 > /trunk/qpid/cpp/src/tests/brokertest.py 1493903 > /trunk/qpid/cpp/src/tests/ipv6_test 1493903 > > Diff: https://reviews.apache.org/r/11915/diff/ > > > Testing > ------- > > cmake: make test > > > Thanks, > > Andrew Stitcher > >
